Skip to content

[platform_tests] Fix test_reboot reboot_type passed as interfaces_wait_time#8725

Merged
wenyiz2021 merged 1 commit intosonic-net:masterfrom
andywongarista:master-fix-test-reboot
Jun 28, 2023
Merged

[platform_tests] Fix test_reboot reboot_type passed as interfaces_wait_time#8725
wenyiz2021 merged 1 commit intosonic-net:masterfrom
andywongarista:master-fix-test-reboot

Conversation

@andywongarista
Copy link
Contributor

@andywongarista andywongarista commented Jun 26, 2023

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

#8646 introduces regression in which a new arg is added to check_interfaces_and_services but the call made from reboot_and_check is not updated to handle the new arg.

This regression causes all of test_reboot.py to fail.

How did you do it?

Fix call in reboot_and_check.

How did you verify/test it?

Tested on arista device.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@andywongarista andywongarista requested a review from prgeor as a code owner June 26, 2023 22:21
@andywongarista
Copy link
Contributor Author

andywongarista commented Jun 26, 2023

@wenyiz2021 FYI

@wenyiz2021
Copy link
Contributor

wenyiz2021 commented Jun 26, 2023

hi @andywongarista thanks for the fix.
can we change the new argument to end of function?
def check_interfaces_and_services(dut, interfaces, xcvr_skip_list,
interfaces_wait_time=MAX_WAIT_TIME_FOR_INTERFACES, reboot_type=None):

to

def check_interfaces_and_services(dut, interfaces, xcvr_skip_list,
reboot_type=None, interfaces_wait_time=MAX_WAIT_TIME_FOR_INTERFACES):

@wenyiz2021
Copy link
Contributor

wenyiz2021 commented Jun 26, 2023

hi @andywongarista thanks for the fix. can we change the new argument to end of function? def check_interfaces_and_services(dut, interfaces, xcvr_skip_list, interfaces_wait_time=MAX_WAIT_TIME_FOR_INTERFACES, reboot_type=None):

to

def check_interfaces_and_services(dut, interfaces, xcvr_skip_list, reboot_type=None, interfaces_wait_time=MAX_WAIT_TIME_FOR_INTERFACES):

nvm, seems only 2 places pass defaul arguments. this change LGTM.

@wenyiz2021 wenyiz2021 merged commit 2e6212c into sonic-net:master Jun 28, 2023
@wenyiz2021 wenyiz2021 mentioned this pull request Jun 28, 2023
Closed
6 tasks
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jun 29, 2023
@andywongarista @mssonicbld
Fix test_reboot reboot_type passed as interfaces_wait_time (sonic-net…
0347c41 
…#8725)
@mssonicbld
Copy link
Collaborator

mssonicbld commented Jun 29, 2023

Cherry-pick PR to 202205: #8771

@mssonicbld mssonicbld mentioned this pull request Jun 29, 2023
Merged
6 tasks
mssonicbld pushed a commit that referenced this pull request Jun 29, 2023
@andywongarista @mssonicbld
Fix test_reboot reboot_type passed as interfaces_wait_time (#8725)
628b3b3
@wenyiz2021 wenyiz2021 mentioned this pull request Jul 10, 2023
Merged
6 tasks
wangxin pushed a commit that referenced this pull request Jul 11, 2023
@wenyiz2021
[Cherry pick 8646] [T2 chassis] platform tests that uses pdu_controll…
f61ff7f 
…er to run on sup for chassis (#8892)

This is cherry-pick of #8646
the extend PR of #8646, #8725 is already merged into 202205 and is non-destructive.
mrkcmo pushed a commit to Azarack/sonic-mgmt that referenced this pull request Oct 3, 2023
@andywongarista @parmarkj
Fix test_reboot reboot_type passed as interfaces_wait_time (sonic-net…
5bacd15 
…#8725)
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
@andywongarista @AharonMalkin
Fix test_reboot reboot_type passed as interfaces_wait_time (sonic-net…
1aa9fd6 
…#8725)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenyiz2021 wenyiz2021 wenyiz2021 approved these changes

@prgeor prgeor Awaiting requested review from prgeor

Assignees

No one assigned

Labels

Approved for 202205 branch Included in 202205 branch Request for 202205 branch

Projects

SONiC Chassis
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andywongarista @wenyiz2021 @mssonicbld @wangxin